Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/api.cc

Issue 10825196: Allow SetHiddenValue to accept empty value. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3281 matching lines...) Expand 10 before | Expand all | Expand 10 after
3292 i::HandleScope scope(isolate); 3292 i::HandleScope scope(isolate);
3293 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3293 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3294 return i::JSObject::GetIdentityHash(self); 3294 return i::JSObject::GetIdentityHash(self);
3295 } 3295 }
3296 3296
3297 3297
3298 bool v8::Object::SetHiddenValue(v8::Handle<v8::String> key, 3298 bool v8::Object::SetHiddenValue(v8::Handle<v8::String> key,
3299 v8::Handle<v8::Value> value) { 3299 v8::Handle<v8::Value> value) {
3300 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3300 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3301 ON_BAILOUT(isolate, "v8::Object::SetHiddenValue()", return false); 3301 ON_BAILOUT(isolate, "v8::Object::SetHiddenValue()", return false);
3302 if (value.IsEmpty()) return DeleteHiddenValue(key);
3302 ENTER_V8(isolate); 3303 ENTER_V8(isolate);
3303 i::HandleScope scope(isolate); 3304 i::HandleScope scope(isolate);
3304 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3305 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3305 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 3306 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
3306 i::Handle<i::String> key_symbol = FACTORY->LookupSymbol(key_obj); 3307 i::Handle<i::String> key_symbol = FACTORY->LookupSymbol(key_obj);
3307 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value); 3308 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
3308 i::Handle<i::Object> result = 3309 i::Handle<i::Object> result =
3309 i::JSObject::SetHiddenProperty(self, key_symbol, value_obj); 3310 i::JSObject::SetHiddenProperty(self, key_symbol, value_obj);
3310 return *result == *self; 3311 return *result == *self;
3311 } 3312 }
(...skipping 3208 matching lines...) Expand 10 before | Expand all | Expand 10 after
6520 6521
6521 v->VisitPointers(blocks_.first(), first_block_limit_); 6522 v->VisitPointers(blocks_.first(), first_block_limit_);
6522 6523
6523 for (int i = 1; i < blocks_.length(); i++) { 6524 for (int i = 1; i < blocks_.length(); i++) {
6524 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6525 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6525 } 6526 }
6526 } 6527 }
6527 6528
6528 6529
6529 } } // namespace v8::internal 6530 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698