Refactor our IL instruction for static setters.

vm/parser.cc

Index: vm/parser.cc
===================================================================
--- vm/parser.cc	(revision 10216)
+++ vm/parser.cc	(working copy)
@@ -6470,7 +6470,9 @@
 AstNode* Parser::CreateAssignmentNode(AstNode* original, AstNode* rhs) {
   AstNode* result = original->MakeAssignmentNode(rhs);
   if ((result != NULL) &&
-      (result->IsStoreIndexedNode() || result->IsInstanceSetterNode())) {
+      (result->IsStoreIndexedNode() ||
+       result->IsInstanceSetterNode() ||
+       result->IsStaticSetterNode())) {

[hausner, 2012/08/03 22:32:52]

FWIW, I don't think that for static setters you need to ensure that a temporary
variable is available. We don't do any gymnastics with static setters in
PrepareCompoundAssignmentNodes().

[Florian Schneider, 2012/08/06 09:06:25]

We still need to preserve the value if the setter expression occurs in a value
context: var x = A.foo = 123.

     EnsureExpressionTemp();
   }
   return result;