Issue 10825135: Issue 4238. Infer Element subclass from query() parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825135: Issue 4238. Infer Element subclass from query() parameter (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4238. Infer Element subclass from query() parameter http://code.google.com/p/dart/issues/detail?id=4238 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10128

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+424 lines, -157 lines)			Patch
A	compiler/java/com/google/dart/compiler/type/ExternalTypeAnalyzers.java	View	1 chunk	+175 lines, -0 lines	1 comment	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	5 chunks	+54 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	6 chunks	+52 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	39 chunks	+133 lines, -150 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 4 months ago (2012-08-01 17:45:46 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10825135/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/type/ExternalTypeAnalyzers.java
(right):

https://chromiumcodereview.appspot.com/10825135/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/type/ExternalTypeAnalyzers.java:23: *
Provides type information which can not be inferred from source itself.
nit: "can not" --> "cannot", here and below

Expand Messages | Collapse Messages