Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10825135: Issue 4238. Infer Element subclass from query() parameter (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
index e82aec45a3829ca334ab8a8e08526037f80c012a..7087de2a1877af897609ec8c15665f12219db9b6 100644
--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -1248,16 +1248,18 @@ public class TypeAnalyzer implements DartCompilationPhase {
Type receiver = nonVoidTypeOf(target);
Member member = lookupMember(receiver, name, nameNode);
if (member != null) {
- Element methodElement = member.getElement();
- checkIllegalPrivateAccess(node.getFunctionName(), methodElement, name);
- node.setElement(methodElement);
+ element = member.getElement();
+ checkIllegalPrivateAccess(node.getFunctionName(), element, name);
+ node.setElement(element);
if (nameNode != null) {
- nameNode.setElement(methodElement);
+ nameNode.setElement(element);
}
}
checkDeprecated(nameNode, nameNode.getElement());
FunctionType methodType = getMethodType(receiver, member, name, nameNode);
- return checkInvocation(node, nameNode, name, methodType);
+ Type returnType = checkInvocation(node, nameNode, name, methodType);
+ returnType = ExternalTypeAnalyzers.resolve(types, node, element, returnType);
+ return returnType;
}
private void checkIllegalPrivateAccess(DartNode diagnosticNode, Element element, String name) {
@@ -2302,7 +2304,9 @@ public class TypeAnalyzer implements DartCompilationPhase {
break;
}
checkDeprecated(target, element);
- return checkInvocation(node, target, name, type);
+ Type returnType = checkInvocation(node, target, name, type);
+ returnType = ExternalTypeAnalyzers.resolve(types, node, element, returnType);
+ return returnType;
}
/**

Powered by Google App Engine
This is Rietveld 408576698