Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: chrome/browser/favicon/select_favicon_frames.h

Issue 10824319: Give SelectFaviconFrames a quality score. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/select_favicon_frames.h
diff --git a/chrome/browser/favicon/select_favicon_frames.h b/chrome/browser/favicon/select_favicon_frames.h
index 07493c93e0d145fae2161cff3c570ab27f1603df..2db30feac6443516d58bb736e78919b6f44bbec4 100644
--- a/chrome/browser/favicon/select_favicon_frames.h
+++ b/chrome/browser/favicon/select_favicon_frames.h
@@ -19,9 +19,15 @@ class ImageSkia;
// ImageSkia that's desired_size x desired_size pixels big. This
// function adds a representation at every desired scale factor.
// If desired_size is 0, the largest bitmap is returned unmodified.
+// If score is non-NULL, it receive a score between 0 (bad) and 1 (good)
+// that describes how well |bitmaps| were able to produce an image at
+// |desired_size| for |scale_factors|.
+// The score is arbitrary, but it's best for exact size matches,
+// and gets worse the more resampling needs to happen..
gfx::ImageSkia SelectFaviconFrames(
const std::vector<SkBitmap>& bitmaps,
const std::vector<ui::ScaleFactor>& scale_factors,
- int desired_size);
+ int desired_size,
+ float* score);
#endif // CHROME_BROWSER_FAVICON_SELECT_FAVICON_FRAMES_H_

Powered by Google App Engine
This is Rietveld 408576698