Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2186)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10824319: Give SelectFaviconFrames a quality score. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index 649527224d2320742a7ed224d7447cb3d0478778..be89f38ea203e1d6658d7468edae9b50b70b54e9 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -195,6 +195,7 @@ void FaviconTabHelper::OnDidDownloadFavicon(
bool errored,
int requested_size,
const std::vector<SkBitmap>& bitmaps) {
+ float score;
// TODO: Possibly do bitmap selection in FaviconHandler, so that it can score
// favicons better.
std::vector<ui::ScaleFactor> scale_factors;
@@ -203,9 +204,12 @@ void FaviconTabHelper::OnDidDownloadFavicon(
#else
scale_factors.push_back(ui::SCALE_FACTOR_100P); // TODO: Aura?
#endif
- gfx::Image favicon(
- SelectFaviconFrames(bitmaps, scale_factors, requested_size));
- favicon_handler_->OnDidDownloadFavicon(id, image_url, errored, favicon);
- if (touch_icon_handler_.get())
- touch_icon_handler_->OnDidDownloadFavicon(id, image_url, errored, favicon);
+ gfx::Image favicon(SelectFaviconFrames(
+ bitmaps, scale_factors, requested_size, &score));
+ favicon_handler_->OnDidDownloadFavicon(
+ id, image_url, errored, favicon, score);
+ if (touch_icon_handler_.get()) {
+ touch_icon_handler_->OnDidDownloadFavicon(
+ id, image_url, errored, favicon, score);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698