Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 10824318: Revert 151653 - Roll DEPS for gyp r1463:r1469. (Closed)

Created:
8 years, 4 months ago by bradn
Modified:
8 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 151653 - Roll DEPS for gyp r1463:r1469. This was causing build failures on the Win2008 dbg builder. http://chromesshgw.corp.google.com/i/chromium/builders/Win%20Builder%202008%20%28dbg%29/builds/4501 r1464: Use flock-style lock on Windows to limit number of concurrent links r1465: Fix usage of shlex in unit tests on windows. r1466: Fixes an issue where OutputDirectory and IntermediateDirectory were being incorrectly generated without a trailing slash on MSVS 2008. r1467: This makes it easier to test combinations of msvs version without having to muck with environment variables r1468: Fix the Android Eclipse CDT generator. r1469: Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting the scripts early. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10836254 TBR=newt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
bradn
8 years, 4 months ago (2012-08-15 19:47:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698