Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10836254: Roll DEPS for gyp r1463:r1469. (Closed)

Created:
8 years, 4 months ago by newt (away)
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, Satish, scottmg
Visibility:
Public.

Description

Roll DEPS for gyp r1463:r1469. r1464: Use flock-style lock on Windows to limit number of concurrent links r1465: Fix usage of shlex in unit tests on windows. r1466: Fixes an issue where OutputDirectory and IntermediateDirectory were being incorrectly generated without a trailing slash on MSVS 2008. r1467: This makes it easier to test combinations of msvs version without having to muck with environment variables r1468: Fix the Android Eclipse CDT generator. r1469: Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting the scripts early. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
newt (away)
This includes jgreenwald's CL "Fix the Android Eclipse CDT generator": http://codereview.chromium.org/10823266/
8 years, 4 months ago (2012-08-15 00:21:50 UTC) #1
Nico
lgtm scottmg: fyi for the winja change
8 years, 4 months ago (2012-08-15 02:33:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10836254/1
8 years, 4 months ago (2012-08-15 02:34:11 UTC) #3
commit-bot: I haz the power
Try job failure for 10836254-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 04:07:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/10836254/1
8 years, 4 months ago (2012-08-15 04:15:10 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 04:26:06 UTC) #6
Change committed as 151653

Powered by Google App Engine
This is Rietveld 408576698