Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10824293: Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting (Closed)

Created:
8 years, 4 months ago by iannucci
Modified:
8 years, 4 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting the scripts early. There are three cases: * Command is a batch file * Command is an exe/com * Command is a builtin (to cmd.exe). In the first case, call will prevent the overall command action from aborting when multiple commands are attached to the same file (look for 'and also' in the msvs generator). In the second, call does not change the exe's behavior In the third case, call still performs the requested action correctly. This even applies to the 'call' builtin, so, 'call call echo foo' is still correct. Committed: https://code.google.com/p/gyp/source/detail?r=1469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M pylib/gyp/generator/msvs.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
iannucci
PTAL
8 years, 4 months ago (2012-08-14 19:48:51 UTC) #1
scottmg
On 2012/08/14 19:48:51, iannucci wrote: > PTAL lgtm. It would be great to be able ...
8 years, 4 months ago (2012-08-14 19:56:13 UTC) #2
iannucci
On 2012/08/14 19:56:13, scottmg wrote: > On 2012/08/14 19:48:51, iannucci wrote: > > PTAL > ...
8 years, 4 months ago (2012-08-14 20:33:01 UTC) #3
scottmg
8 years, 4 months ago (2012-08-14 20:36:49 UTC) #4
On 2012/08/14 20:33:01, iannucci wrote:
> On 2012/08/14 19:56:13, scottmg wrote:
> > On 2012/08/14 19:48:51, iannucci wrote:
> > > PTAL
> > 
> > lgtm. It would be great to be able to add a test too. Perhaps you could
> prepend
> > something to the PATH that contains a python.bat (or whatever name) and
verify
> > that the second step runs?
> 
> I thought about that, but AFAIK, the issue only happens when executing under
> incredibuild, and not under msvs. I figured that the existing tests would be
> enough to ensure that all the current functionality works as intended.

OK.

Powered by Google App Engine
This is Rietveld 408576698