pylib/gyp/generator/msvs.py - Issue 10824293: Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/msvs.py

Issue 10824293: Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/generator/msvs.py

===================================================================

--- pylib/gyp/generator/msvs.py (revision 1468)

+++ pylib/gyp/generator/msvs.py (working copy)

@@ -294,6 +294,11 @@

command = ['type']

else:

command = [cmd[0].replace('/', '\\')]

+ # Add call before command to ensure that commands can be tied together one

+ # after the other without aborting in Incredibuild, since IB makes a bat

+ # file out of the raw command string, and some commands (like python) are

+ # actually batch files themselves.

+ command.insert(0, 'call')

# Fix the paths

# TODO(quote): This is a really ugly heuristic, and will miss path fixing

# for arguments like "--arg=path" or "/opt:path".

« no previous file with comments | « no previous file | no next file » | no next file with comments »