Issue 10824265: Correctly remove file browser notifications from Ash notification tray.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824265: Correctly remove file browser notifications from Ash notification tray. (Closed)

Created:
8 years, 4 months ago by stevenjb

Modified:
8 years, 4 months ago

Reviewers:
Lei Zhang, tbarzic

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Correctly remove file browser notifications from Ash notification tray. Also added replace_id to DesktopNotificationService::AddNotification so that notifications are correctly replaced/updated. BUG=135286 For minor changes to status_icons/ background/ and printing/: TBR=atwilson@chromium.org,thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151305

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -20 lines)			Patch
M	chrome/browser/background/background_contents_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_notifications.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_notifications.cc	View		3 chunks	+26 lines, -7 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.h	View		1 chunk	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View	1	6 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/status_icons/desktop_notification_balloon.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

8 years, 4 months ago (2012-08-17 04:46:00 UTC) #3

lgtm, but please remember to CC the TBR'd reviewers next time.

Expand Messages | Collapse Messages