chrome/browser/status_icons/desktop_notification_balloon.cc - Issue 10824265: Correctly remove file browser notifications from Ash notification tray.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/status_icons/desktop_notification_balloon.cc

Issue 10824265: Correctly remove file browser notifications from Ash notification tray. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/status_icons/desktop_notification_balloon.h"	5 #include "chrome/browser/status_icons/desktop_notification_balloon.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/string_number_conversions.h"	8 #include "base/string_number_conversions.h"

9 #include "base/threading/thread_restrictions.h"	9 #include "base/threading/thread_restrictions.h"

10 #include "chrome/browser/browser_process.h"	10 #include "chrome/browser/browser_process.h"

(...skipping 65 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
76 const string16& contents) {	76 const string16& contents) {

77 // Allowing IO access is required here to cover the corner case where	77 // Allowing IO access is required here to cover the corner case where

78 // there is no last used profile and the default one is loaded.	78 // there is no last used profile and the default one is loaded.

79 // IO access won't be required for normal uses.	79 // IO access won't be required for normal uses.

80 Profile* profile;	80 Profile* profile;

81 {	81 {

82 base::ThreadRestrictions::ScopedAllowIO allow_io;	82 base::ThreadRestrictions::ScopedAllowIO allow_io;

83 profile = ProfileManager::GetLastUsedProfile();	83 profile = ProfileManager::GetLastUsedProfile();

84 }	84 }

85 notification_id_ = DesktopNotificationService::AddIconNotification(	85 notification_id_ = DesktopNotificationService::AddIconNotification(

86 GURL(), title, contents, gfx::ImageSkia(icon),	86 GURL(), title, contents, gfx::ImageSkia(icon), string16(),

87 new DummyNotificationDelegate(base::IntToString(id_count_++)), profile);	87 new DummyNotificationDelegate(base::IntToString(id_count_++)), profile);

88 }	88 }

OLD	NEW