chrome UI: change UI string "Last Updated" to "Build Date".

chrome UI: change UI string "Last Updated" to "Build Date".

The UI string should reflect the true nature of the date. The date is in fact when the Chrome OS image is built, not when it is installed on the device.

BUG=132561
TEST=locally verified on lumpy.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150924

[hshi1, 2012-08-09 19:04:18]

Hi Achuith and Alex, can you comment on this UI string change?

I'm modifying a few more files than minimally necessary, as I feel it is better
to fix the function name as well.

[achuithb, 2012-08-09 19:44:59]

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/resources/he...
File chrome/browser/resources/help/help.js (right):

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/resources/he...
chrome/browser/resources/help/help.js:237: setBuildDate_: function(buildDate) {
Is this cros-only or for all of chrome? I'm assuming this is cros-only

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/ui/webui/hel...
File chrome/browser/ui/webui/help/help_handler.cc (right):

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/ui/webui/hel...
chrome/browser/ui/webui/help/help_handler.cc:107: Value* g_build_date_string =
NULL;
This is pretty sketchy. There must be some other place you can stick this info
into. Have you looked at:
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/chromeos/sy...

[hshi1, 2012-08-09 19:46:15]

P.S. the file "chrome/app/generated_resources.grd" exceeds the file size limit
imposed by upload.py (called by git-cl), so this file does not have side-by-side
diff. The rest 3 files do have side-by-side support. Sorry about that.

[hshi1, 2012-08-09 19:51:15]

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/resources/he...
File chrome/browser/resources/help/help.js (right):

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/resources/he...
chrome/browser/resources/help/help.js:237: setBuildDate_: function(buildDate) {
Although not very obvious, this is indeed for cros-only, because this part of JS
code is only invoked by help_handler.cc where the corresponding code is enclosed
in "#if defined(OS_CHROMEOS) ... #endif" guards.

On 2012/08/09 19:45:00, achuith.bhandarkar wrote:
> Is this cros-only or for all of chrome? I'm assuming this is cros-only

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/ui/webui/hel...
File chrome/browser/ui/webui/help/help_handler.cc (right):

http://codereview.chromium.org/10824214/diff/7001/chrome/browser/ui/webui/hel...
chrome/browser/ui/webui/help/help_handler.cc:107: Value* g_build_date_string =
NULL;
Thanks for the suggestion and I agree this can be done in a better way. However
my goal with this patch is just to update the UI string and call it a day (as
you suggested in the bug). I'd prefer to leave functionality changes to a
separate patch.

On 2012/08/09 19:45:00, achuith.bhandarkar wrote:
> This is pretty sketchy. There must be some other place you can stick this info
> into. Have you looked at:
>
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/chromeos/sy...

[hshi1, 2012-08-09 20:02:47]

Add khorimoto@ who originally implemented the "Last Updated" string in the about
page (see http://codereview.chromium.org/10038034).

[achuithb, 2012-08-09 20:07:22]

On 2012/08/09 19:46:15, hshi1 wrote:
> P.S. the file "chrome/app/generated_resources.grd" exceeds the file size limit
> imposed by upload.py (called by git-cl), so this file does not have
side-by-side
> diff. The rest 3 files do have side-by-side support. Sorry about that.

Yup, that's normal.

[hshi1, 2012-08-09 20:36:31]

Added jhawkins@ as owner of chrome/app and chrome/browser/ui; removed kuscher@
(not an active user of chromium code reviews).

[Kyle Horimoto, 2012-08-09 20:48:12]

LGTM

You're right - this string is more fitting. (Although I hope that the average
CrOS user understands what "Build Date" means!)

[James Hawkins, 2012-08-09 20:53:20]

lgtm

[commit-bot: I haz the power, 2012-08-09 20:59:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10824214/3003

[commit-bot: I haz the power, 2012-08-09 22:38:33]

Change committed as 150924