Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5183)

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 10824214: chrome UI: change UI string "Last Updated" to "Build Date". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to update the corresponding CSS file. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/help/help.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index 82312fae3d914e2cb15f82f03fb3ae62f5b08c1f..d616a6538b8d1b102bee85439f12b89517e2a278 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -101,10 +101,10 @@ bool CanChangeReleaseChannel() {
return false;
}
-// Pointer to a |StringValue| holding the date of the last update to Chromium
+// Pointer to a |StringValue| holding the date of the build date to Chromium
// OS. Because this value is obtained by reading a file, it is cached here to
// prevent the need to read from the file system multiple times unnecessarily.
-Value* g_last_updated_string = NULL;
+Value* g_build_date_string = NULL;
#endif // defined(OS_CHROMEOS)
@@ -157,7 +157,7 @@ void HelpHandler::GetLocalizedValues(DictionaryValue* localized_strings) {
{ "webkit", IDS_WEBKIT },
{ "userAgent", IDS_ABOUT_VERSION_USER_AGENT },
{ "commandLine", IDS_ABOUT_VERSION_COMMAND_LINE },
- { "lastUpdated", IDS_ABOUT_VERSION_LAST_UPDATED },
+ { "buildDate", IDS_ABOUT_VERSION_BUILD_DATE },
#endif
#if defined(OS_MACOSX)
{ "promote", IDS_ABOUT_CHROME_PROMOTE_UPDATER },
@@ -268,8 +268,8 @@ void HelpHandler::OnPageLoaded(const ListValue* args) {
web_ui()->CallJavascriptFunction(
"help.HelpPage.updateEnableReleaseChannel", *can_change_channel_value);
- if (g_last_updated_string == NULL) {
- // If |g_last_updated_string| is |NULL|, the date has not yet been assigned.
+ if (g_build_date_string == NULL) {
+ // If |g_build_date_string| is |NULL|, the date has not yet been assigned.
// Get the date of the last lsb-release file modification.
base::FileUtilProxy::GetFileInfo(
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
@@ -277,8 +277,8 @@ void HelpHandler::OnPageLoaded(const ListValue* args) {
base::Bind(&HelpHandler::ProcessLsbFileInfo,
weak_factory_.GetWeakPtr()));
} else {
- web_ui()->CallJavascriptFunction("help.HelpPage.setLastUpdated",
- *g_last_updated_string);
+ web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
+ *g_build_date_string);
}
#endif // defined(OS_CHROMEOS)
@@ -434,27 +434,27 @@ void HelpHandler::ProcessLsbFileInfo(
base::PlatformFileError error, const base::PlatformFileInfo& file_info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- // If |g_last_updated_string| is not |NULL|, then the file's information has
+ // If |g_build_date_string| is not |NULL|, then the file's information has
// already been retrieved by another tab.
- if (g_last_updated_string == NULL) {
+ if (g_build_date_string == NULL) {
base::Time time;
if (error == base::PLATFORM_FILE_OK) {
- // Retrieves the approximate time at which Chrome OS was last updated.
+ // Retrieves the time at which the Chrome OS build was created.
// Each time a new build is created, /etc/lsb-release is modified with the
// new version numbers of the release.
time = file_info.last_modified;
} else {
- // If the time of the last update cannot be retrieved, return and do not
- // display the "Last Updated" section.
+ // If the time of the build cannot be retrieved, return and do not
+ // display the "Build Date" section.
return;
}
// Note that this string will be internationalized.
- string16 last_updated = base::TimeFormatFriendlyDate(time);
- g_last_updated_string = Value::CreateStringValue(last_updated);
+ string16 build_date = base::TimeFormatFriendlyDate(time);
+ g_build_date_string = Value::CreateStringValue(build_date);
}
- web_ui()->CallJavascriptFunction("help.HelpPage.setLastUpdated",
- *g_last_updated_string);
+ web_ui()->CallJavascriptFunction("help.HelpPage.setBuildDate",
+ *g_build_date_string);
}
#endif // defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/resources/help/help.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698