Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10824188: Always send an ExtensionMsg_Loaded message before ExtensionMsg_ActivateExtension (Closed)

Created:
8 years, 4 months ago by not at google - send to devlin
Modified:
8 years, 4 months ago
Reviewers:
Aaron Boodman, jam
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Always send an ExtensionMsg_Loaded message before ExtensionMsg_ActivateExtension so that ExtensionDispatcher knows what Extension is active, not just its ID. BUG=139869 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150453

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 1 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
Speculative fix for the bug, but I have a good feeling about it... https://chromiumcodereview.appspot.com/10824188/diff/3002/chrome/browser/renderer_host/chrome_render_view_host_observer.cc File ...
8 years, 4 months ago (2012-08-06 22:54:48 UTC) #1
Aaron Boodman
Yeah, ok. I still wish that we could understand why the two places we're already ...
8 years, 4 months ago (2012-08-06 23:07:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10824188/3002
8 years, 4 months ago (2012-08-06 23:10:58 UTC) #3
commit-bot: I haz the power
Presubmit check for 10824188-3002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-06 23:11:01 UTC) #4
not at google - send to devlin
+jam
8 years, 4 months ago (2012-08-06 23:15:33 UTC) #5
jam
lgtm
8 years, 4 months ago (2012-08-07 16:10:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10824188/3002
8 years, 4 months ago (2012-08-07 22:03:18 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 23:48:41 UTC) #8
Change committed as 150453

Powered by Google App Engine
This is Rietveld 408576698