Always send an ExtensionMsg_Loaded message before ExtensionMsg_ActivateExtension

chrome/browser/renderer_host/chrome_render_view_host_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/net/predictor.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 103 matching lines @@
           process->GetID(), chrome::kFileScheme);
     }
   }
 
   switch (type) {
     case Extension::TYPE_EXTENSION:
     case Extension::TYPE_USER_SCRIPT:
     case Extension::TYPE_HOSTED_APP:
     case Extension::TYPE_PACKAGED_APP:
     case Extension::TYPE_PLATFORM_APP:
+      // Always send a Loaded message before ActivateExtension so that
+      // ExtensionDispatcher knows what Extension is active, not just its ID.
+      // This is important for classifying the Extension's JavaScript context
+      // correctly (see ExtensionDispatcher::ClassifyJavaScriptContext).
+      Send(new ExtensionMsg_Loaded(

[not at google - send to devlin, 2012/08/06 22:54:48]

Maybe this could go in InitRenderViewHostForExtensions? Not confident of that.

Or better, make this work with the loading code in ExtensionService.

But there was that "chrome.experimental undefined on startup" bug which seems
quite similar, and was fixed by changing this file.

+          std::vector<ExtensionMsg_Loaded_Params>(
+              1, ExtensionMsg_Loaded_Params(extension))));
       Send(new ExtensionMsg_ActivateExtension(extension->id()));
       break;
 
     case Extension::TYPE_UNKNOWN:
     case Extension::TYPE_THEME:
       break;
   }
 }
 
 const Extension* ChromeRenderViewHostObserver::GetExtension() {
@@ skipping 29 matching lines @@
   if (process_manager)
     process_manager->UnregisterRenderViewHost(rvh);
 }
 
 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED,
       content::Source<RenderViewHost>(render_view_host()),
       content::NotificationService::NoDetails());
 }