Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 10824156: Remove CHECK and NOTREACHED for mouse lock, fix full screen transition. (Closed)

Created:
8 years, 4 months ago by nfullagar
Modified:
8 years, 4 months ago
Reviewers:
jschuh, brettw, viettrungluu
CC:
chromium-reviews, scheib+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove CHECK and NOTREACHED for mouse lock, fix full screen transition. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2937 TEST=From Dust, ppapi tests

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_mouse_lock_rpc_server.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nfullagar
8 years, 4 months ago (2012-08-02 23:53:35 UTC) #1
jschuh
8 years, 4 months ago (2012-08-03 00:19:12 UTC) #2
jschuh
lgtm
8 years, 4 months ago (2012-08-03 00:19:17 UTC) #3
viettrungluu
https://chromiumcodereview.appspot.com/10824156/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): https://chromiumcodereview.appspot.com/10824156/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode1636 webkit/plugins/ppapi/ppapi_plugin_instance.cc:1636: if (!TrackedCallback::IsPending(lock_mouse_callback_)) { Get rid of the braces (for ...
8 years, 4 months ago (2012-08-03 00:50:04 UTC) #4
viettrungluu
(LGTM with style nit fixed, though.) On 2012/08/03 00:50:04, viettrungluu wrote: > https://chromiumcodereview.appspot.com/10824156/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc > File ...
8 years, 4 months ago (2012-08-03 00:50:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10824156/6
8 years, 4 months ago (2012-08-03 01:11:39 UTC) #6
commit-bot: I haz the power
Change committed as 149789
8 years, 4 months ago (2012-08-03 02:48:22 UTC) #7
Brad Chen
8 years, 4 months ago (2012-08-03 16:57:50 UTC) #8
On 2012/08/03 02:48:22, I haz the power (commit-bot) wrote:
> Change committed as 149789

This change has been approved for merge into the M21 release branch. Nicholas
can you please merge into 1180 and 1180_87?

Powered by Google App Engine
This is Rietveld 408576698