Remove CHECK and NOTREACHED for mouse lock, fix full screen transition.

webkit/plugins/ppapi/ppapi_plugin_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 1615 matching lines @@
 bool PluginInstance::IsProcessingUserGesture() {
   PP_TimeTicks now =
       ::ppapi::TimeTicksToPPTimeTicks(base::TimeTicks::Now());
   // Give a lot of slack so tests won't be flaky. Well behaved plugins will
   // close the user gesture.
   const PP_TimeTicks kUserGestureDurationInSeconds = 10.0;
   return (now - pending_user_gesture_ < kUserGestureDurationInSeconds);
 }
 
 void PluginInstance::OnLockMouseACK(bool succeeded) {
   if (!TrackedCallback::IsPending(lock_mouse_callback_)) {

[viettrungluu, 2012/08/03 00:50:04]

Get rid of the braces (for consistency with the other one-line |if|s in this
file).

Or, better yet, change this to:

if (TrackedCallback::IsPending(...)) {
  TrackedCallback::ClearAndRun(...
                               ...);
}

-    NOTREACHED();
     return;
   }
   TrackedCallback::ClearAndRun(&lock_mouse_callback_,
                                succeeded ? PP_OK : PP_ERROR_FAILED);
 }
 
 void PluginInstance::OnMouseLockLost() {
   if (LoadMouseLockInterface())
     plugin_mouse_lock_interface_->MouseLockLost(pp_instance());
 }
@@ skipping 595 matching lines @@
   screen_size_for_fullscreen_ = gfx::Size();
   WebElement element = container_->element();
   element.setAttribute(WebString::fromUTF8(kWidth), width_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kHeight), height_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kBorder), border_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kStyle), style_before_fullscreen_);
 }
 
 }  // namespace ppapi
 }  // namespace webkit