Issue 10824152: Merge 123798 - Guard Prerenderer against inserting prerenders into detached documents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824152: Merge 123798 - Guard Prerenderer against inserting prerenders into detached documents. (Closed)

Created:
8 years, 4 months ago by gavinp

Modified:
8 years, 4 months ago

Reviewers:
gavinp

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Visibility:
Public.

More Reviews

Description

Merge 123798 - Guard Prerenderer against inserting prerenders into detached documents. https://bugs.webkit.org/show_bug.cgi?id=92401 Reviewed by Adam Barth. Source/WebCore: If the document is detached, we should not launch a prerender. Test: fast/dom/HTMLLinkElement/prerender-insert-after-stop.html * loader/Prerenderer.cpp: (WebCore::Prerenderer::render): LayoutTests: If the document is detached, we should just not launch a prerender. * fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Added. * fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Added. * fast/dom/HTMLLinkElement/resources/empty2.html: Added. TBR=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124494

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12996 lines, --3 lines)			Patch
M	LayoutTests/ChangeLog	View	1 chunk	+5768 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLLinkElement/resources/empty2.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/ChangeLog	View	1 chunk	+7227 lines, -0 lines	0 comments	Download
M	Source/WebCore/loader/Prerenderer.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages