Issue 10824151: Try to fix a crash in the new sync machine code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824151: Try to fix a crash in the new sync machine code (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Try to fix a crash in the new sync machine code This adds back the fallback code that was deleted after the 10.6 migration in https://chromiumcodereview.appspot.com/10807052, it's necessary again. BUG=140256, 138570 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149715

Patch Set 3 : . #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	sync/util/get_session_name_mac.mm	View	1 2	2 chunks	+26 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM http://codereview.chromium.org/10824151/diff/3/sync/util/get_session_name_mac.mm File sync/util/get_session_name_mac.mm (right): http://codereview.chromium.org/10824151/diff/3/sync/util/get_session_name_mac.mm#newcode31 sync/util/get_session_name_mac.mm:31: if (computer_name.get() != NULL) nit: remove the != ...

8 years, 4 months ago (2012-08-02 20:24:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10824151/6001

8 years, 4 months ago (2012-08-02 20:27:29 UTC) #4

Change committed as 149715

Expand Messages | Collapse Messages

Issue 10824151: Try to fix a crash in the new sync machine code (Closed)

Description

Patch Set 1 #

Patch Set 2 : err #

Patch Set 3 : . #

Messages