Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10807052: mac: Remove code that was only needed on 10.5 (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
Robert Sesek, jeremy
CC:
chromium-reviews, cbentzel+watch_chromium.org, jennb, jam, Dmitry Titov, jianli, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, tim (not reviewing), Mark Mentovai, jeremy, davidben
Visibility:
Public.

Description

mac: Remove code that was only needed on 10.5 BUG=137676 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147738

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : kill workspaceIDCache_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -246 lines) Patch
M chrome/browser/mac/dock.mm View 1 chunk +4 lines, -63 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_button.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm View 1 2 4 chunks +2 lines, -65 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tracking_area.h View 1 chunk +1 line, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area.mm View 1 chunk +7 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/wrench_menu/menu_tracked_button.mm View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/backing_store_mac.mm View 1 2 chunks +1 line, -21 lines 0 comments Download
M content/common/common.sb View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_mac.mm View 3 chunks +3 lines, -13 lines 0 comments Download
M content/ppapi_plugin/ppapi.sb View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/renderer.sb View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/cert_verify_proc_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/util/get_session_name_mac.mm View 1 chunk +1 line, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
timsteele: FYI sync change mark: FYI dock change jeremy: FYI sandbox change
8 years, 5 months ago (2012-07-20 17:15:13 UTC) #1
jeremy
Sandbox changes LGTM, thanks for the cleanup! https://chromiumcodereview.appspot.com/10807052/diff/6002/content/common/common.sb File content/common/common.sb (right): https://chromiumcodereview.appspot.com/10807052/diff/6002/content/common/common.sb#newcode27 content/common/common.sb:27: ; 10.5.6, ...
8 years, 5 months ago (2012-07-20 17:52:52 UTC) #2
Nico
Thanks! https://chromiumcodereview.appspot.com/10807052/diff/6002/content/common/common.sb File content/common/common.sb (right): https://chromiumcodereview.appspot.com/10807052/diff/6002/content/common/common.sb#newcode27 content/common/common.sb:27: ; 10.5.6, 10.6 On 2012/07/20 17:52:53, jeremy wrote: ...
8 years, 5 months ago (2012-07-20 17:54:47 UTC) #3
Robert Sesek
https://chromiumcodereview.appspot.com/10807052/diff/6002/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm (left): https://chromiumcodereview.appspot.com/10807052/diff/6002/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm#oldcode515 chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm:515: workspaceIDCache_.find(windowID); Can you delete workspaceIDCache_ too?
8 years, 5 months ago (2012-07-20 17:59:36 UTC) #4
Nico
davidben: tabstripdragcontroller changes fyi https://chromiumcodereview.appspot.com/10807052/diff/6002/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm (left): https://chromiumcodereview.appspot.com/10807052/diff/6002/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm#oldcode515 chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm:515: workspaceIDCache_.find(windowID); On 2012/07/20 17:59:36, rsesek ...
8 years, 5 months ago (2012-07-20 18:02:13 UTC) #5
Robert Sesek
LGTM! /me does a happy dance
8 years, 5 months ago (2012-07-20 18:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10807052/14001
8 years, 5 months ago (2012-07-20 19:24:01 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 19:24:23 UTC) #8 
Presubmit check for 10807052-14001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
Banned functions were used.
    chrome/browser/ui/cocoa/tracking_area.mm:71:
      The use of NSTrackingAreas is prohibited. Please use CrTrackingArea
      instead.
      http://dev.chromium.org/developers/coding-style/cocoa-dos-and-donts

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    sync
    content/renderer
    content/ppapi_plugin
    net
    content/common
    chrome/browser/ui/panels

Presubmit checks took 2.5s to calculate.

Powered by Google App Engine
This is Rietveld 408576698