Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4646)

Unified Diff: chrome/common/extensions/extension.h

Issue 10824149: Fix memory leak in ActiveTabPermissionManager. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/active_tab_permission_manager.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index bb1b43413f27cff2b59fd7a0eee9b86cf9c6a87b..d3c3bcb0d21233cd5ff804ed17c3f7d91a7a4993 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -571,8 +571,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Updates the tab-specific permissions of |tab_id| to include those from
// |permissions|.
- void UpdateTabSpecificPermissions(int tab_id,
- const PermissionSet* permissions) const;
+ void UpdateTabSpecificPermissions(
+ int tab_id,
+ scoped_refptr<const PermissionSet> permissions) const;
// Clears the tab-specific permissions of |tab_id|.
void ClearTabSpecificPermissions(int tab_id) const;
@@ -728,8 +729,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
scoped_refptr<const PermissionSet> GetTabSpecificPermissions(int tab_id)
const;
- void UpdateTabSpecificPermissions(int tab_id,
- const PermissionSet* permissions);
+ void UpdateTabSpecificPermissions(
+ int tab_id,
+ scoped_refptr<const PermissionSet> permissions);
void ClearTabSpecificPermissions(int tab_id);
private:
« no previous file with comments | « chrome/browser/extensions/active_tab_permission_manager.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698