chrome/browser/extensions/active_tab_permission_manager.cc - Issue 10824149: Fix memory leak in ActiveTabPermissionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_manager.cc

Issue 10824149: Fix memory leak in ActiveTabPermissionManager. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/active_tab_permission_manager.cc

diff --git a/chrome/browser/extensions/active_tab_permission_manager.cc b/chrome/browser/extensions/active_tab_permission_manager.cc

index 67d6d58243137341ec85b9ce06cc5e456d053dbd..6b6fd6c43a1833addfdee89ed26517a527663d75 100644

--- a/chrome/browser/extensions/active_tab_permission_manager.cc

+++ b/chrome/browser/extensions/active_tab_permission_manager.cc

@@ -53,9 +53,10 @@ void ActiveTabPermissionManager::GrantIfRequested(const Extension* extension) {

new_apis.insert(APIPermission::kTab);

URLPatternSet new_hosts;

new_hosts.AddPattern(pattern);

+ scoped_refptr<const PermissionSet> new_permissions =

+ new PermissionSet(new_apis, new_hosts, URLPatternSet());

- extension->UpdateTabSpecificPermissions(

- tab_id_, new PermissionSet(new_apis, new_hosts, URLPatternSet()));

+ extension->UpdateTabSpecificPermissions(tab_id_, new_permissions);

granted_extensions_.Insert(extension);

Send(new ExtensionMsg_UpdateTabSpecificPermissions(GetPageID(),

tab_id_,

« no previous file with comments | « no previous file | chrome/common/extensions/extension.h » ('j') | no next file with comments »