Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: build/common.gypi

Issue 10824055: mac: Let mac_sdk default to the oldest available SDK that's at least 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: bots Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | build/mac/find_sdk.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5b38b2334b2eb5cc2d197d41a0cdb815da72ad6c..ff8bd0b4e77390419875e5e159ccf76c8e3e9c5a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -643,7 +643,7 @@
# Chrome normally builds with the Mac OS X 10.6 SDK and sets the
# deployment target to 10.5. Other projects, such as O3D, may override
# these defaults.
- 'mac_sdk%': '10.6',
+ 'mac_sdk%': '<!(python mac/find_sdk.py)',
Mark Mentovai 2012/07/27 03:31:30 I wouldn’t want this to impact official builds. Co
Nico 2012/07/27 18:01:05 Explicitly setting mac_sdk still overrides the out
Mark Mentovai 2012/07/27 18:18:35 Nico wrote:
'mac_deployment_target%': '10.5',
# The default value for mac_strip in target_defaults. This cannot be
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | build/mac/find_sdk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698