Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: build/common.gypi

Issue 10824055: mac: Let mac_sdk default to the oldest available SDK that's at least 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: bots Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | build/mac/find_sdk.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 # available in the headers. 636 # available in the headers.
637 # The deployment target identifies the minimum system version that the 637 # The deployment target identifies the minimum system version that the
638 # built products are expected to function on. It corresponds to the 638 # built products are expected to function on. It corresponds to the
639 # MAC_OS_X_VERSION_MIN_REQUIRED compile-time macro. 639 # MAC_OS_X_VERSION_MIN_REQUIRED compile-time macro.
640 # To ensure these macros are available, #include <AvailabilityMacros.h>. 640 # To ensure these macros are available, #include <AvailabilityMacros.h>.
641 # Additional documentation on these macros is available at 641 # Additional documentation on these macros is available at
642 # http://developer.apple.com/mac/library/technotes/tn2002/tn2064.html#SECTIO N3 642 # http://developer.apple.com/mac/library/technotes/tn2002/tn2064.html#SECTIO N3
643 # Chrome normally builds with the Mac OS X 10.6 SDK and sets the 643 # Chrome normally builds with the Mac OS X 10.6 SDK and sets the
644 # deployment target to 10.5. Other projects, such as O3D, may override 644 # deployment target to 10.5. Other projects, such as O3D, may override
645 # these defaults. 645 # these defaults.
646 'mac_sdk%': '10.6', 646 'mac_sdk%': '<!(python mac/find_sdk.py)',
Mark Mentovai 2012/07/27 03:31:30 I wouldn’t want this to impact official builds. Co
Nico 2012/07/27 18:01:05 Explicitly setting mac_sdk still overrides the out
Mark Mentovai 2012/07/27 18:18:35 Nico wrote:
647 'mac_deployment_target%': '10.5', 647 'mac_deployment_target%': '10.5',
648 648
649 # The default value for mac_strip in target_defaults. This cannot be 649 # The default value for mac_strip in target_defaults. This cannot be
650 # set there, per the comment about variable% in a target_defaults. 650 # set there, per the comment about variable% in a target_defaults.
651 'mac_strip_release%': 1, 651 'mac_strip_release%': 1,
652 652
653 # Set to 1 to enable code coverage. In addition to build changes 653 # Set to 1 to enable code coverage. In addition to build changes
654 # (e.g. extra CFLAGS), also creates a new target in the src/chrome 654 # (e.g. extra CFLAGS), also creates a new target in the src/chrome
655 # project file called "coverage". 655 # project file called "coverage".
656 # Currently ignored on Windows. 656 # Currently ignored on Windows.
(...skipping 2663 matching lines...) Expand 10 before | Expand all | Expand 10 after
3320 # settings in target dicts. SYMROOT is a special case, because many other 3320 # settings in target dicts. SYMROOT is a special case, because many other
3321 # Xcode variables depend on it, including variables such as 3321 # Xcode variables depend on it, including variables such as
3322 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3322 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3323 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3323 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3324 # files to appear (when present) in the UI as actual files and not red 3324 # files to appear (when present) in the UI as actual files and not red
3325 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3325 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3326 # and therefore SYMROOT, needs to be set at the project level. 3326 # and therefore SYMROOT, needs to be set at the project level.
3327 'SYMROOT': '<(DEPTH)/xcodebuild', 3327 'SYMROOT': '<(DEPTH)/xcodebuild',
3328 }, 3328 },
3329 } 3329 }
OLDNEW
« no previous file with comments | « no previous file | build/mac/find_sdk.py » ('j') | build/mac/find_sdk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698