Issue 10824006: Revert 148272 - Refactor the wallpaper encoding to another file/class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824006: Revert 148272 - Refactor the wallpaper encoding to another file/class. (Closed)

Created:
8 years, 5 months ago by Hironori Bono

Modified:
8 years, 5 months ago

Reviewers:
rkc

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 148272 - Refactor the wallpaper encoding to another file/class. Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too. R=bshe@chromium.org,csilv@chromium.org BUG=None. TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed. Review URL: https://chromiumcodereview.appspot.com/10790084 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148278

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -148 lines)			Patch
D	chrome/browser/ui/webui/options2/chromeos/simple_png_encoder.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/chromeos/simple_png_encoder.cc	View	1 chunk	+0 lines, -66 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/wallpaper_source.h	View	2 chunks	+2 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc	View	2 chunks	+91 lines, -21 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

8 years, 5 months ago (2012-07-25 03:57:15 UTC) #2

Greetings Rahul,

Apologies for reverting your change. I have reverted this change because it
caused assertion errors when the "Linux ChromiumOS Tests (dbg)(3)" bot ran
interactive_ui_tests as listed in the following URL. If I recall correctly, we
can run interactive_ui_tests on trybots when using a '--bot
linux:interactive_ui_tests' option. Would it be possible to try this option for
your next change?

(*1)
<http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...>

Regards,

Hironori Bono

Expand Messages | Collapse Messages