Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 10790084: Refactor the wallpaper encoding to another file/class. (Closed)

Created:
8 years, 5 months ago by rkc
Modified:
8 years, 5 months ago
Reviewers:
csilv, bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Refactor the wallpaper encoding to another file/class. Encoding the wallpaper to png from a skia is something we'll need to do from at least one more place (the screensaver images source) so it makes sense to refactor this code to pull out the encoder so it's usable from other places too. R=bshe@chromium.org,csilv@chromium.org BUG=None. TEST=Tested with the lock screen to verify that the background set for the user is pulled and displayed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148272

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -93 lines) Patch
A chrome/browser/ui/webui/options2/chromeos/simple_png_encoder.h View 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options2/chromeos/simple_png_encoder.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_source.h View 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc View 1 2 chunks +21 lines, -91 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rkc
8 years, 5 months ago (2012-07-19 22:53:55 UTC) #1
rkc
On 2012/07/19 22:53:55, Rahul Chaturvedi wrote: Reviews request, bshe - main review csilv - owners ...
8 years, 5 months ago (2012-07-19 22:54:25 UTC) #2
bshe
On 2012/07/19 22:54:25, Rahul Chaturvedi wrote: > On 2012/07/19 22:53:55, Rahul Chaturvedi wrote: > > ...
8 years, 5 months ago (2012-07-20 17:56:40 UTC) #3
csilv
lgtm w/ nit. http://codereview.chromium.org/10790084/diff/1/chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc File chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc (right): http://codereview.chromium.org/10790084/diff/1/chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc#newcode17 chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc:17: extern "C" { Looks like we ...
8 years, 5 months ago (2012-07-23 21:35:18 UTC) #4
rkc
http://codereview.chromium.org/10790084/diff/1/chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc File chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc (right): http://codereview.chromium.org/10790084/diff/1/chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc#newcode17 chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc:17: extern "C" { On 2012/07/23 21:35:18, csilv wrote: > ...
8 years, 5 months ago (2012-07-24 23:01:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/10790084/5001
8 years, 5 months ago (2012-07-24 23:01:53 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 01:24:10 UTC) #7
Change committed as 148272

Powered by Google App Engine
This is Rietveld 408576698