Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8

chrome/installer/util/work_item_list.h

Index: chrome/installer/util/work_item_list.h
diff --git a/chrome/installer/util/work_item_list.h b/chrome/installer/util/work_item_list.h
index 5f50fe45b43fa060912709633863adc016b9042e..3931649004fa829833e29b547b7200a6a23d16db 100644
--- a/chrome/installer/util/work_item_list.h
+++ b/chrome/installer/util/work_item_list.h
@@ -113,6 +113,15 @@ class WorkItemList : public WorkItem {
                                            int64 value_data,
                                            bool overwrite);
 
+  // Add an "optional" boolean registry value, specified by value_data.

[gab, 2012/08/28 16:08:19]

Remove quotes around "optional"

[grt (UTC plus 2), 2012/08/28 19:35:40]

i think this function is too special-purpose to belong here.  i think it's more
clear for the three callers to do the work themselves.  you could add a private
helper function to app_command.cc if you'd like.

[huangs, 2012/08/29 17:02:54]

Moved to app_command.cc as local helper.

+  // In the registry, a non-zero value is "true", and a missing or zero value
+  // is "false". If value_data == true, add a SetRegValueWorkItem that sets
+  // registry value of 1 with REG_DWORD type.  Otherwise add a
+  // DeleteRegValueWorkItem that deletes the registry value.
+  virtual WorkItem* AddSetOptionalBoolRegValueWorkItem(

[gab, 2012/08/28 16:08:19]

I believe all other methods in this file are tested. Add a test for this new
method.

[huangs, 2012/08/29 17:02:54]

No longer need to test!

+      HKEY predefined_root, const std::wstring& key_path,

[gab, 2012/08/28 16:08:19]

Use string16

[huangs, 2012/08/29 17:02:54]

Now I no longer need to change this file.  Should I make this change anyway?

+      const std::wstring& value_name, bool value_data);
+
   // Add a SelfRegWorkItem that registers or unregisters a DLL at the
   // specified path. If user_level_registration is true, then alternate
   // registration and unregistration entry point names will be used.