Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/installer/util/work_item_list.cc

Issue 10823437: Callback flow to register Chrome and update shortcuts after OS upgrade to Windows 8 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reimplementing registry changes using AppCommand; adding checks in InstallationValidator. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/work_item_list.cc
diff --git a/chrome/installer/util/work_item_list.cc b/chrome/installer/util/work_item_list.cc
index f9808c0c511c319b8a678cfdd80a90a1310207be..f927ed03f9dadad4bda698134c1bdcb95f247ecb 100644
--- a/chrome/installer/util/work_item_list.cc
+++ b/chrome/installer/util/work_item_list.cc
@@ -198,6 +198,17 @@ WorkItem* WorkItemList::AddSetRegValueWorkItem(HKEY predefined_root,
return item;
}
+WorkItem* WorkItemList::AddSetOptionalBoolRegValueWorkItem(
+ HKEY predefined_root, const std::wstring& key_path,
+ const std::wstring& value_name, bool value_data) {
gab 2012/08/28 16:08:19 string16
huangs 2012/08/29 17:02:54 No longer need change this file.
+ if (value_data) {
+ return AddSetRegValueWorkItem(predefined_root, key_path, value_name,
+ (DWORD) 1, true);
gab 2012/08/28 16:08:19 s/(DWORD) 1/static_cast<DWORD>(1)
huangs 2012/08/29 17:02:54 Done (in app_command.cc).
+ } else {
+ return AddDeleteRegValueWorkItem(predefined_root, key_path, value_name);
+ }
+}
+
WorkItem* WorkItemList::AddSelfRegWorkItem(const std::wstring& dll_path,
bool do_register,
bool user_level_registration) {
« chrome/installer/util/work_item_list.h ('K') | « chrome/installer/util/work_item_list.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698