Make sure controller is properly reset when the picker is closed.

Make sure controller is properly reset when the picker is closed.

R=sky@chromium.org
BUG=143484
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153165

[groby-ooo-7-16, 2012-08-20 21:49:24]

Re-assigning to sky@ (thestig OOO, intents owners OOO)

[sky, 2012-08-20 23:08:20]

LGTM

https://chromiumcodereview.appspot.com/10823424/diff/1/chrome/browser/ui/inte...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

https://chromiumcodereview.appspot.com/10823424/diff/1/chrome/browser/ui/inte...
chrome/browser/ui/intents/web_intent_picker_controller.cc:695:
DCHECK(dialog_state_ == kPickerHidden);
DCHECK_EQ

[groby-ooo-7-16, 2012-08-21 03:40:30]

https://chromiumcodereview.appspot.com/10823424/diff/1/chrome/browser/ui/inte...
File chrome/browser/ui/intents/web_intent_picker_controller.cc (right):

https://chromiumcodereview.appspot.com/10823424/diff/1/chrome/browser/ui/inte...
chrome/browser/ui/intents/web_intent_picker_controller.cc:695:
DCHECK(dialog_state_ == kPickerHidden);
On 2012/08/20 23:08:20, sky wrote:
> DCHECK_EQ

Done.

[commit-bot: I haz the power, 2012-08-21 03:40:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10823424/6001

[commit-bot: I haz the power, 2012-08-21 03:40:51]

Failed to apply patch for
chrome/browser/ui/intents/web_intent_picker_controller.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/intents/web_intent_picker_controller.cc
Hunk #2 FAILED at 883.
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/intents/web_intent_picker_controller.cc.rej

[commit-bot: I haz the power, 2012-08-21 03:49:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10823424/9001

[commit-bot: I haz the power, 2012-08-21 04:56:12]

Try job failure for 10823424-9001 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-23 21:27:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10823424/13001

[commit-bot: I haz the power, 2012-08-23 22:59:12]

Try job failure for 10823424-13001 (retry) on mac_rel for step "browser_tests"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-24 00:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10823424/18003

[commit-bot: I haz the power, 2012-08-24 05:06:01]

Change committed as 153165