Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 10823424: Make sure controller is properly reset when the picker is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix browser tests. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index 90788a3b2c4a38591010c60ed75570a493aa4b19..c362cc767bbaad6ea8a748c68026f358ac76accc 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -690,6 +690,24 @@ void WebIntentPickerController::OnIntentDataArrived() {
OnPickerEvent(kPickerEventAsyncDataComplete);
}
+void WebIntentPickerController::Reset() {
+ // Abandon all callbacks.
+ weak_ptr_factory_.InvalidateWeakPtrs();
+ timer_factory_.InvalidateWeakPtrs();
+
+ // Reset state associated with callbacks.
+ pending_async_count_ = 0;
+ pending_registry_calls_count_ = 0;
+ pending_cws_request_ = false;
+
+ // Reset picker.
+ picker_model_.reset(new WebIntentPickerModel());
+ picker_shown_ = false;
+
+ DCHECK(tab_contents_);
+ tab_contents_->constrained_window_tab_helper()->BlockTabContent(false);
+}
+
// static
void WebIntentPickerController::DecodeExtensionIconAndResize(
scoped_ptr<std::string> icon_response,
@@ -862,8 +880,7 @@ void WebIntentPickerController::SetDialogState(WebIntentPickerState state) {
break;
case kPickerHidden:
- // Once the picker dialog is closed, abandon all pending callbacks.
- weak_ptr_factory_.InvalidateWeakPtrs();
+ Reset();
break;
default:

Powered by Google App Engine
This is Rietveld 408576698