Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10823423: Change dart2js_foreign suite to use metadata. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
kasperl, ngeoffray, sra1
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Change dart2js_foreign suite to use metadata. Committed: https://code.google.com/p/dart/source/detail?r=11026

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -296 lines) Patch
M dart/tests/compiler/dart2js_foreign/native_call_arity1_test.dart View 2 chunks +11 lines, -8 lines 2 comments Download
M dart/tests/compiler/dart2js_foreign/native_call_arity2_test.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_call_arity3_test.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_checked_arguments1_test.dart View 2 chunks +13 lines, -10 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_checked_fields_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart View 2 chunks +12 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart View 2 chunks +19 lines, -14 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_inheritance2_test.dart View 2 chunks +17 lines, -12 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_inheritance3_test.dart View 2 chunks +17 lines, -12 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_inheritance4_test.dart View 4 chunks +9 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_is_check1_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_is_check3_test.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_class_with_dart_methods_test.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_closure_identity_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_exceptions1_test.dart View 3 chunks +13 lines, -9 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_field_rename_1_test.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_field_rename_2_test.dart View 3 chunks +11 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib1.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_library_same_name_used_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_literal_class_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_method_rename1_test.dart View 2 chunks +9 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_method_rename2_test.dart View 2 chunks +13 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_method_rename3_test.dart View 3 chunks +13 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_method_with_keyword_name_test.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_missing_method1_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_missing_method2_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_named_constructors2_test.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_named_constructors3_test.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_no_such_method_exception2_test.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_no_such_method_exception3_test.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_no_such_method_exception4_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_no_such_method_exception5_test.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_no_such_method_exception_test.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_null_closure_test.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_null_test.dart View 1 chunk +14 lines, -8 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_parameter_names_test.dart View 1 chunk +10 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_property_test.dart View 2 chunks +27 lines, -12 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_to_string_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_use_native_name_in_table_test.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_window1_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_window2_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_wrapping_function2_test.dart View 1 chunk +17 lines, -10 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_wrapping_function3_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M dart/tests/compiler/dart2js_foreign/native_wrapping_function_test.dart View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
Consider if we want to use different metadata tags for different things. Right now, it ...
8 years, 4 months ago (2012-08-20 21:30:11 UTC) #1
sra1
I'm OK with this as is, or with some changes. I'm not sure what naming ...
8 years, 4 months ago (2012-08-21 00:56:14 UTC) #2
kasperl
LGTM. I agree with Stephen that using annotations allow us to start having multiple different ...
8 years, 4 months ago (2012-08-21 05:53:59 UTC) #3
ngeoffray
STV! Thanks Peter for doing this. Once that's in, we can refine the annotations for ...
8 years, 4 months ago (2012-08-21 06:34:18 UTC) #4
ahe
8 years, 4 months ago (2012-08-21 10:14:14 UTC) #5
I agree, we shouldn't use @native for everything. But I'll focus on providing
making metadata available, and leave it to others to convert our native
implementation to use metadata.

One more thing: I think it would be nice to avoid "*A" on classes. I feel it
would be better if there was a separate metadata tag for each kind of symbol
that can be used in that position, so instead of:

@native("*A") you would write @nativeClass("A")

@native("@*DOMWindow") you would write
@nativeAsIfIKnowWhatThisMeans("DOMWindow").

Powered by Google App Engine
This is Rietveld 408576698