Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 10823366: Adds platform support for DeviceMotion tests in WebKit (Closed)

Created:
8 years, 4 months ago by aousterh
Modified:
8 years, 4 months ago
Reviewers:
tkent, hans
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adds platform support for DeviceMotion tests in WebKit This implements the function deviceMotionDetector which will be added to Platform.h. This depends on the WebKit patch at (https://bugs.webkit.org/show_bug.cgi?id=89197). That WebKit patch will need to be split in two and landed as a 3-sided patch. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webkit/support/test_webkit_platform_support.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aousterh
8 years, 4 months ago (2012-08-16 15:47:42 UTC) #1
hans
lgtm tkent: webkit/support/OWNERS review?
8 years, 4 months ago (2012-08-16 16:41:23 UTC) #2
tkent
LGTM
8 years, 4 months ago (2012-08-17 00:58:35 UTC) #3
hans
8 years, 4 months ago (2012-08-20 13:37:40 UTC) #4
Re-uploading this patch here: https://chromiumcodereview.appspot.com/10827415/

Powered by Google App Engine
This is Rietveld 408576698