Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 10823356: Merge 123637 - (Closed)

8 years, 4 months ago by tkent
8 years, 4 months ago
Base URL:


Merge 123637 - REGRESSION (r112919): Setting scrollTop after setting display from none to block fails -and corresponding- <rdar://problem/11656050> Reviewed by Simon Fraser. Source/WebCore: ScrollAnimatorMac::immediateScrollTo() and ScrollAnimatorMac::immediateScrollBy() both have an optimization in place so that they do not call notifyPositionChanged() if the new scroll offset matches the ScrollAnimator's cached m_currentPosX and m_currentPosY. So revision 112919 caused troubled with this optimization because it allowed RenderLayers to restore a scrollOffset from the Element if there is one cached there. This caused the RenderLayer to have a scrollOffset that is improperly out-of-synch with the ScrollAnimator's currentPosition (which will just be 0,0 since it is being re-created like the RenderLayer). This fix makes sure they are in synch by calling setCurrentPosition() on the ScrollAnimator when the cached position is non-zero. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): LayoutTests: * fast/overflow/setting-scrollTop-after-hide-show-expected.txt: Added. * fast/overflow/setting-scrollTop-after-hide-show.html: Added. Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --2 lines) Patch
A + LayoutTests/fast/overflow/setting-scrollTop-after-hide-show.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/overflow/setting-scrollTop-after-hide-show-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 2 chunks +3 lines, -0 lines 0 comments Download


Total messages: 1 (0 generated)
8 years, 4 months ago (2012-08-16 01:26:24 UTC) #1


Powered by Google App Engine
This is Rietveld 408576698