In the declarative API, check that the extension has permission for the event

In the declarative API, check that the extension has permission for the event
that it tries to modify.


BUG=141093
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150723

[Matt Perry, 2012-08-09 01:08:19]

lgtm

[not at google - send to devlin, 2012-08-09 01:19:25]

Hey Matt, I changed the way it works, sorry.

Forgot about the new way that extension functions can override HasPermission to
do custom permission checks. This seems like an appropriate use of that
functionality.

[not at google - send to devlin, 2012-08-09 01:20:53]

(PTAL)

[Matt Perry, 2012-08-09 01:31:50]

lgtm

https://chromiumcodereview.appspot.com/10823247/diff/9004/chrome/browser/exte...
File chrome/browser/extensions/api/declarative/declarative_api.cc (right):

https://chromiumcodereview.appspot.com/10823247/diff/9004/chrome/browser/exte...
chrome/browser/extensions/api/declarative/declarative_api.cc:77: bool
RulesFunction::Init() {
optional: I would get rid of the Init() step, and just call GetString twice.
Sure it's lame, but it's simpler and not really a perf bottleneck.

[not at google - send to devlin, 2012-08-09 01:41:44]

https://chromiumcodereview.appspot.com/10823247/diff/9004/chrome/browser/exte...
File chrome/browser/extensions/api/declarative/declarative_api.cc (right):

https://chromiumcodereview.appspot.com/10823247/diff/9004/chrome/browser/exte...
chrome/browser/extensions/api/declarative/declarative_api.cc:77: bool
RulesFunction::Init() {
On 2012/08/09 01:31:50, Matt Perry wrote:
> optional: I would get rid of the Init() step, and just call GetString twice.
> Sure it's lame, but it's simpler and not really a perf bottleneck.

Done.

[commit-bot: I haz the power, 2012-08-09 01:42:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/10823247/10002

[commit-bot: I haz the power, 2012-08-09 04:04:39]

Change committed as 150723