In the declarative API, check that the extension has permission for the event

chrome/browser/extensions/api/declarative/declarative_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative/declarative_api.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/task_runner_util.h"
 #include "base/values.h"
@@ skipping 24 matching lines @@
 }
 
 }  // namespace
 
 namespace extensions {
 
 RulesFunction::RulesFunction() : rules_registry_(NULL) {}
 
 RulesFunction::~RulesFunction() {}
 
+bool RulesFunction::HasPermission() {
+  return Init() && extension_->HasAPIPermission(event_name_);
+}
+
 bool RulesFunction::RunImpl() {
-  std::string event_name;
-  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &event_name));
+  EXTENSION_FUNCTION_VALIDATE(Init());
 
   RulesRegistryService* rules_registry_service =
       ExtensionSystemFactory::GetForProfile(profile())->
       rules_registry_service();
-  rules_registry_ = rules_registry_service->GetRulesRegistry(event_name);
+  rules_registry_ = rules_registry_service->GetRulesRegistry(event_name_);
   // Raw access to this function is not available to extensions, therefore
   // there should never be a request for a nonexisting rules registry.
   EXTENSION_FUNCTION_VALIDATE(rules_registry_);
 
   if (content::BrowserThread::CurrentlyOn(rules_registry_->GetOwnerThread())) {
     bool success = RunImplOnCorrectThread();
     SendResponse(success);
   } else {
     scoped_refptr<base::MessageLoopProxy> message_loop_proxy =
         content::BrowserThread::GetMessageLoopProxyForThread(
             rules_registry_->GetOwnerThread());
     base::PostTaskAndReplyWithResult(
         message_loop_proxy,
         FROM_HERE,
         base::Bind(&RulesFunction::RunImplOnCorrectThread, this),
         base::Bind(&RulesFunction::SendResponse, this));
   }
 
   return true;
 }
 
+bool RulesFunction::Init() {

[Matt Perry, 2012/08/09 01:31:50]

optional: I would get rid of the Init() step, and just call GetString twice.
Sure it's lame, but it's simpler and not really a perf bottleneck.

[not at google - send to devlin, 2012/08/09 01:41:44]

Done.

+  if (!event_name_.empty())
+    return true;
+  return args_->GetString(0, &event_name_);
+}
+
 bool AddRulesFunction::RunImplOnCorrectThread() {
   scoped_ptr<AddRules::Params> params(AddRules::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   error_ = rules_registry_->AddRules(extension_id(), params->rules);
 
   if (error_.empty())
     results_ = AddRules::Results::Create(params->rules);
 
   return error_.empty();
@@ skipping 26 matching lines @@
     error_ = rules_registry_->GetAllRules(extension_id(), &rules);
   }
 
   if (error_.empty())
     results_ = GetRules::Results::Create(rules);
 
   return error_.empty();
 }
 
 }  // namespace extensions