Don't count SLOW tests towards failure.

Don't count SLOW tests towards failure.

Also adds 2 tests which weren't being counted:
http/tests/security/video-cross-origin-readback.html
http/tests/security/video-poster-cross-origin-crash.html

BUG=140583
TEST=Ran layout test analyzer.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150639

[DaleCurtis, 2012-08-08 20:26:05]

Bumps us up to 98%!

[Ami GONE FROM CHROMIUM, 2012-08-08 20:32:27]

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if 'SKIP' in x or
'SLOW' in x]):
A SLOW line that has anything to the right of the = other than PASS should still
ding us, though.

[DaleCurtis, 2012-08-08 20:53:54]

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if 'SKIP' in x or
'SLOW' in x]):
On 2012/08/08 20:32:27, Ami Fischman wrote:
> A SLOW line that has anything to the right of the = other than PASS should
still
> ding us, though.

Just PASS? Or PASS + modifiers? There are several lines that have "SLOW PASS
TIMEOUT|TEXT|etc" Although it looks like only video-stall-play is SLOW+PASS at
the moment.

[Ami GONE FROM CHROMIUM, 2012-08-08 20:57:09]

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

https://chromiumcodereview.appspot.com/10823238/diff/1/media/tools/layout_tes...
media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if 'SKIP' in x or
'SLOW' in x]):
On 2012/08/08 20:53:54, DaleCurtis wrote:
> On 2012/08/08 20:32:27, Ami Fischman wrote:
> > A SLOW line that has anything to the right of the = other than PASS should
> still
> > ding us, though.
> 
> Just PASS? Or PASS + modifiers? There are several lines that have "SLOW PASS
> TIMEOUT|TEXT|etc" Although it looks like only video-stall-play is SLOW+PASS at
> the moment.

If there's anything other than PASS to the right of the '=' then that indicates
we still have a problem that needs fixing.  So it should count against our
failure %age.

[DaleCurtis, 2012-08-08 23:47:25]

http://codereview.chromium.org/10823238/diff/1/media/tools/layout_tests/layou...
File media/tools/layout_tests/layouttest_analyzer_helpers.py (right):

http://codereview.chromium.org/10823238/diff/1/media/tools/layout_tests/layou...
media/tools/layout_tests/layouttest_analyzer_helpers.py:67: if 'SKIP' in x or
'SLOW' in x]):
On 2012/08/08 20:57:09, Ami Fischman wrote:
> On 2012/08/08 20:53:54, DaleCurtis wrote:
> > On 2012/08/08 20:32:27, Ami Fischman wrote:
> > > A SLOW line that has anything to the right of the = other than PASS should
> > still
> > > ding us, though.
> > 
> > Just PASS? Or PASS + modifiers? There are several lines that have "SLOW PASS
> > TIMEOUT|TEXT|etc" Although it looks like only video-stall-play is SLOW+PASS
at
> > the moment.
> 
> If there's anything other than PASS to the right of the '=' then that
indicates
> we still have a problem that needs fixing.  So it should count against our
> failure %age.

Done. Although no tests now qualify for SLOW currently.

[Ami GONE FROM CHROMIUM, 2012-08-08 23:51:40]

LGTM

If you wanted a real test case you could run the script on 124689 (in 124690 I
removed some SLOW/PASS tests).

http://codereview.chromium.org/10823238/diff/1003/media/tools/layout_tests/te...
File media/tools/layout_tests/testname/media.csv (right):

http://codereview.chromium.org/10823238/diff/1003/media/tools/layout_tests/te...
media/tools/layout_tests/testname/media.csv:22:
http/tests/security/\S*video\S+.html,
Unrelated change?

[DaleCurtis, 2012-08-08 23:57:37]

I tested with a modified expectations file.

http://codereview.chromium.org/10823238/diff/1003/media/tools/layout_tests/te...
File media/tools/layout_tests/testname/media.csv (right):

http://codereview.chromium.org/10823238/diff/1003/media/tools/layout_tests/te...
media/tools/layout_tests/testname/media.csv:22:
http/tests/security/\S*video\S+.html,
On 2012/08/08 23:51:40, Ami Fischman wrote:
> Unrelated change?

Intended, see description.