Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: media/tools/layout_tests/layouttest_analyzer_helpers.py

Issue 10823238: Don't count SLOW tests towards failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix miscount. Ignore only SLOW PASS. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/tools/layout_tests/layouttest_analyzer_helpers.py
diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py
index 7a133d085420f1312bd75c3bb25f5453d98ce197..300775c4a048c246112ee9dbceabfae2e082ec3b 100644
--- a/media/tools/layout_tests/layouttest_analyzer_helpers.py
+++ b/media/tools/layout_tests/layouttest_analyzer_helpers.py
@@ -63,6 +63,10 @@ class AnalyzerResultMap:
for (k, value) in test_info_map.iteritems():
self.result_map['whole'][k] = value
if 'te_info' in value:
+ # Don't count SLOW PASS tests as failures.
+ if any([True for x in value['te_info'] if set(x.keys()) ==
+ set(['SLOW', 'PASS', 'Bugs', 'Comments'])]):
+ continue
if any([True for x in value['te_info'] if 'SKIP' in x]):
self.result_map['skip'][k] = value
else:
« no previous file with comments | « no previous file | media/tools/layout_tests/testname/media.csv » ('j') | media/tools/layout_tests/testname/media.csv » ('J')

Powered by Google App Engine
This is Rietveld 408576698