Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9514)

Unified Diff: chrome/common/extensions/extension.cc

Issue 10823142: Fix a race condition when an IconAnimation is still running at browser shutdown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/script_badge_controller.cc ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 990271e17965fb76156cfce707cc728c617aec50..2fe50b27c25987ab3189c7d0c669e23b6ec29236 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -806,10 +806,10 @@ scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(
string16* error) {
scoped_ptr<ExtensionAction> result(new ExtensionAction(id(), action_type));
- // Page actions are hidden/disabled by default, and browser actions are
+ // Page/script actions are hidden/disabled by default, and browser actions are
// visible/enabled by default.
result->SetIsVisible(ExtensionAction::kDefaultTabId,
- action_type != ExtensionAction::TYPE_PAGE);
+ action_type == ExtensionAction::TYPE_BROWSER);
if (manifest_version_ == 1) {
const ListValue* icons = NULL;
@@ -2377,8 +2377,6 @@ bool Extension::LoadScriptBadge(string16* error) {
IDR_EXTENSIONS_FAVICON).ToSkBitmap());
}
- script_badge_->SetIsVisible(ExtensionAction::kDefaultTabId, true);
-
return true;
}
« no previous file with comments | « chrome/browser/extensions/script_badge_controller.cc ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698