chrome/browser/extensions/script_badge_controller.cc - Issue 10823142: Fix a race condition when an IconAnimation is still running at browser shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/script_badge_controller.cc

Issue 10823142: Fix a race condition when an IconAnimation is still running at browser shutdown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix nits. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/script_badge_apitest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/script_badge_controller.cc

diff --git a/chrome/browser/extensions/script_badge_controller.cc b/chrome/browser/extensions/script_badge_controller.cc

index c416231475c317661a69832e7f200db18df61cac..5ef797c638a7a0fa67c170d31be7d1be3bb4a4a0 100644

--- a/chrome/browser/extensions/script_badge_controller.cc

+++ b/chrome/browser/extensions/script_badge_controller.cc

@@ -186,6 +186,7 @@ bool ScriptBadgeController::MarkExtensionExecuting(

if (!script_badge)

return false;

+ script_badge->SetIsVisible(SessionID::IdForTab(tab_contents_), true);

script_badge->RunIconAnimation(SessionID::IdForTab(tab_contents_));

return true;

« no previous file with comments | « chrome/browser/extensions/api/extension_action/script_badge_apitest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »