Chromium Code Reviews| Index: runtime/vm/locations.h |
| =================================================================== |
| --- runtime/vm/locations.h (revision 10252) |
| +++ runtime/vm/locations.h (working copy) |
| @@ -23,6 +23,18 @@ |
| // enumeration), constant locations contain a tagged (low 2 bits are set to 01) |
| // Object handle |
| class Location : public ValueObject { |
| + private: |
| + enum { |
| + // Number of bits required to encode Kind value. |
| + kBitsForKind = 3, |
| + kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind, |
| + }; |
| + |
| + static const uword kInvalidLocation = 0; |
| + static const uword kConstantMask = 0x3; |
| + static const intptr_t kStackIndexBias = |
| + static_cast<intptr_t>(1) << (kBitsForPayload - 1); |
| + |
|
siva
2012/08/04 01:21:50
Similar comment about private: coming before publi
|
| public: |
| // Constant payload can overlap with kind field so Kind values |
| // have to be chosen in a way that their last 2 bits are never |
| @@ -49,15 +61,6 @@ |
| kStackSlot = 4, |
| }; |
| - enum { |
| - // Number of bits required to encode Kind value. |
| - kBitsForKind = 3, |
| - kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind, |
| - }; |
| - |
| - static const uword kInvalidLocation = 0; |
| - static const uword kConstantMask = 0x3; |
| - |
| Location() : value_(kInvalidLocation) { |
| ASSERT(IsInvalid()); |
| } |
| @@ -148,8 +151,6 @@ |
| } |
| // Spill slots. |
| - static const intptr_t kStackIndexBias = |
| - static_cast<intptr_t>(1) << (kBitsForPayload - 1); |
| static Location StackSlot(intptr_t stack_index) { |
| ASSERT((-kStackIndexBias <= stack_index) && |
| (stack_index < kStackIndexBias)); |