Add deopt info to code object and print it

runtime/vm/locations.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOCATIONS_H_
 #define VM_LOCATIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/bitfield.h"
 
 namespace dart {
 
 class BufferFormatter;
 
 // Location objects are used to connect register allocator and code generator.
 // Instruction templates used by code generator have a corresponding
 // LocationSummary object which specifies expected location for every input
 // and output.
 // Each location is encoded as a single word: for non-constant locations
 // low 3 bits denote location kind, rest is kind specific location payload
 // e.g. for REGISTER kind payload is register code (value of the Register
 // enumeration), constant locations contain a tagged (low 2 bits are set to 01)
 // Object handle
 class Location : public ValueObject {
+ private:
+  enum {
+    // Number of bits required to encode Kind value.
+    kBitsForKind = 3,
+    kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind,
+  };
+
+  static const uword kInvalidLocation = 0;
+  static const uword kConstantMask = 0x3;
+  static const intptr_t kStackIndexBias =
+      static_cast<intptr_t>(1) << (kBitsForPayload - 1);
+

[siva, 2012/08/04 01:21:50]

Similar comment about private: coming before public:

  public:
   // Constant payload can overlap with kind field so Kind values
   // have to be chosen in a way that their last 2 bits are never
   // the same as kConstant.
   enum Kind {
     // This location is invalid.  Payload must be zero.
     kInvalid = 0,
 
     // Constant value. This location contains a tagged Object handle.
     kConstant = 1,
 
     // Unallocated location represents a location that is not fixed and can be
     // allocated by a register allocator.  Each unallocated location has
     // a policy that specifies what kind of location is suitable. Payload
     // contains register allocation policy.
     kUnallocated = 2,
 
     // Register location represents a fixed register.  Payload contains
     // register code.
     kRegister = 3,
 
     // Spill slot allocated by the register allocator.  Payload contains
     // a spill index.
     kStackSlot = 4,
   };
 
-  enum {
-    // Number of bits required to encode Kind value.
-    kBitsForKind = 3,
-    kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind,
-  };
-
-  static const uword kInvalidLocation = 0;
-  static const uword kConstantMask = 0x3;
-
   Location() : value_(kInvalidLocation) {
     ASSERT(IsInvalid());
   }
 
   bool IsInvalid() const {
     return value_ == kInvalidLocation;
   }
 
   // Constants.
   bool IsConstant() const {
@@ skipping 70 matching lines @@
   bool IsRegister() const {
     return kind() == kRegister;
   }
 
   Register reg() const {
     ASSERT(IsRegister());
     return static_cast<Register>(payload());
   }
 
   // Spill slots.
-  static const intptr_t kStackIndexBias =
-      static_cast<intptr_t>(1) << (kBitsForPayload - 1);
   static Location StackSlot(intptr_t stack_index) {
     ASSERT((-kStackIndexBias <= stack_index) &&
            (stack_index < kStackIndexBias));
     Location loc(kStackSlot, static_cast<uword>(kStackIndexBias + stack_index));
     // Ensure that sign is preserved.
     ASSERT(loc.stack_index() == stack_index);
     return loc;
   }
 
   bool IsStackSlot() const {
@@ skipping 120 matching lines @@
   GrowableArray<Location> temp_locations_;
   Location output_location_;
 
   const bool is_call_;
 };
 
 
 }  // namespace dart
 
 #endif  // VM_LOCATIONS_H_