Issue 10823050: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823050: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 5 months ago by rpetterson

Modified:
8 years, 4 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148830

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
M	chrome/browser/ui/cocoa/applescript/bookmark_applescript_utils_unittest.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/bookmark_node_applescript.mm	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/view_id_util_browsertest.mm	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10823050/1005

8 years, 4 months ago (2012-07-27 17:36:18 UTC) #3

commit-bot: I haz the power

The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...

8 years, 4 months ago (2012-07-27 20:39:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10823050/1005

8 years, 4 months ago (2012-07-27 20:48:19 UTC) #5

Change committed as 148830