Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 10823050: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h" 8 #include "chrome/browser/bookmarks/bookmark_model.h"
9 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
9 #include "chrome/browser/bookmarks/bookmark_utils.h" 10 #include "chrome/browser/bookmarks/bookmark_utils.h"
10 #include "chrome/browser/download/download_shelf.h" 11 #include "chrome/browser/download/download_shelf.h"
11 #include "chrome/browser/prefs/pref_service.h" 12 #include "chrome/browser/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile.h" 13 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/browser.h" 14 #include "chrome/browser/ui/browser.h"
14 #include "chrome/browser/ui/browser_commands.h" 15 #include "chrome/browser/ui/browser_commands.h"
15 #include "chrome/browser/ui/browser_window.h" 16 #include "chrome/browser/ui/browser_window.h"
16 #include "chrome/browser/ui/cocoa/view_id_util.h" 17 #include "chrome/browser/ui/cocoa/view_id_util.h"
17 #include "chrome/browser/ui/tab_contents/tab_contents.h" 18 #include "chrome/browser/ui/tab_contents/tab_contents.h"
18 #include "chrome/common/chrome_switches.h" 19 #include "chrome/common/chrome_switches.h"
(...skipping 29 matching lines...) Expand all
48 49
49 // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED 50 // Make sure docked devtools is created to test VIEW_ID_DEV_TOOLS_DOCKED
50 browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsOpenDocked, 51 browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsOpenDocked,
51 true); 52 true);
52 chrome::ToggleDevToolsWindow(browser(), DEVTOOLS_TOGGLE_ACTION_INSPECT); 53 chrome::ToggleDevToolsWindow(browser(), DEVTOOLS_TOGGLE_ACTION_INSPECT);
53 54
54 // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF 55 // Make sure download shelf is created to test VIEW_ID_DOWNLOAD_SHELF
55 browser()->window()->GetDownloadShelf()->Show(); 56 browser()->window()->GetDownloadShelf()->Show();
56 57
57 // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT 58 // Create a bookmark to test VIEW_ID_BOOKMARK_BAR_ELEMENT
58 BookmarkModel* bookmark_model = browser()->profile()->GetBookmarkModel(); 59 BookmarkModel* bookmark_model =
60 BookmarkModelFactory::GetForProfile(browser()->profile());
59 if (bookmark_model) { 61 if (bookmark_model) {
60 if (!bookmark_model->IsLoaded()) 62 if (!bookmark_model->IsLoaded())
61 ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model); 63 ui_test_utils::WaitForBookmarkModelToLoad(bookmark_model);
62 64
63 bookmark_utils::AddIfNotBookmarked( 65 bookmark_utils::AddIfNotBookmarked(
64 bookmark_model, GURL(chrome::kAboutBlankURL), ASCIIToUTF16("about")); 66 bookmark_model, GURL(chrome::kAboutBlankURL), ASCIIToUTF16("about"));
65 } 67 }
66 68
67 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) { 69 for (int i = VIEW_ID_TOOLBAR; i < VIEW_ID_PREDEFINED_COUNT; ++i) {
68 // Mac implementation does not support following ids yet. 70 // Mac implementation does not support following ids yet.
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 // VIEW_ID_TAB_LAST should always be available. 114 // VIEW_ID_TAB_LAST should always be available.
113 CheckViewID(VIEW_ID_TAB_LAST, true); 115 CheckViewID(VIEW_ID_TAB_LAST, true);
114 } 116 }
115 117
116 // Open the 11th tab. 118 // Open the 11th tab.
117 browser()->OpenURL(OpenURLParams( 119 browser()->OpenURL(OpenURLParams(
118 GURL(chrome::kAboutBlankURL), Referrer(), NEW_BACKGROUND_TAB, 120 GURL(chrome::kAboutBlankURL), Referrer(), NEW_BACKGROUND_TAB,
119 content::PAGE_TRANSITION_TYPED, false)); 121 content::PAGE_TRANSITION_TYPED, false));
120 CheckViewID(VIEW_ID_TAB_LAST, true); 122 CheckViewID(VIEW_ID_TAB_LAST, true);
121 } 123 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698