Revert r148496 "Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver"

Revert r148496 "Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver"

It broke sync_integration_tests:
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithSameSettings
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithDifferentSettings

TBR=dcheng@chromium.org

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148536

[akalin, 2012-07-26 17:51:57]

Hmm why didn't this close the tree automatically? This is the second time
this CL has landed and been reverted a while after.

Also, I thought the sync integration tests were on the trybots also?
On Jul 26, 2012 5:32 AM, <maruel@chromium.org> wrote:
>
> Reviewers: dcheng,
>
> Description:
> Revert r148496 "Refactor sync-specific parts out of
> SyncNotifier/SyncNotifierObserver"
>
> It broke sync_integration_tests:
> TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithSameSettings
>
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithDifferentSettings
>
> TBR=dcheng@chromium.org
>
> BUG=
> TEST=
>
>
> Please review this at https://chromiumcodereview.appspot.com/10823037/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/browser/sync/glue/DEPS
>   M chrome/browser/sync/glue/bridged_sync_notifier.h
>   M chrome/browser/sync/glue/bridged_sync_notifier.cc
>   M chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
>   M chrome/browser/sync/glue/chrome_sync_notification_bridge.h
>   M chrome/browser/sync/glue/chrome_sync_notification_bridge.cc
>   M chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc
>   M sync/internal_api/sync_manager_impl.h
>   M sync/internal_api/sync_manager_impl.cc
>   M sync/internal_api/syncapi_unittest.cc
>   M sync/notifier/chrome_invalidation_client.h
>   M sync/notifier/invalidation_notifier.h
>   M sync/notifier/invalidation_notifier.cc
>   M sync/notifier/invalidation_notifier_unittest.cc
>   M sync/notifier/invalidation_util.h
>   M sync/notifier/invalidation_util.cc
>   M sync/notifier/mock_sync_notifier_observer.h
>   M sync/notifier/non_blocking_invalidation_notifier.h
>   M sync/notifier/non_blocking_invalidation_notifier.cc
>   M sync/notifier/non_blocking_invalidation_notifier_unittest.cc
>   D sync/notifier/object_id_payload_map.h
>   D sync/notifier/object_id_payload_map.cc
>   M sync/notifier/p2p_notifier.h
>   M sync/notifier/p2p_notifier.cc
>   M sync/notifier/p2p_notifier_unittest.cc
>   M sync/notifier/sync_notifier.h
>   M sync/notifier/sync_notifier_factory_unittest.cc
>   D sync/notifier/sync_notifier_helper.h
>   D sync/notifier/sync_notifier_helper.cc
>   D sync/notifier/sync_notifier_helper_unittest.cc
>   M sync/notifier/sync_notifier_observer.h
>   M sync/sync.gyp
>   M sync/tools/sync_listen_notifications.cc
>
>

[M-A Ruel, 2012-07-26 18:04:43]

2012/7/26 Fred Akalin <akalin@chromium.org>

> Hmm why didn't this close the tree automatically? This is the second time
> this CL has landed and been reverted a while after.
>
It's not in gatekeeper configuration.
http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromi...


> Also, I thought the sync integration tests were on the trybots also?
>
It's not on the CQ:
http://src.chromium.org/viewvc/chrome/trunk/tools/commit-queue/projects.py?vi...



> On Jul 26, 2012 5:32 AM, <maruel@chromium.org> wrote:
> >
> > Reviewers: dcheng,
> >
> > Description:
> > Revert r148496 "Refactor sync-specific parts out of
> > SyncNotifier/SyncNotifierObserver"
> >
> > It broke sync_integration_tests:
> >
> TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithSameSettings
> >
>
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithDifferentSettings
> >
> > TBR=dcheng@chromium.org
> >
> > BUG=
> > TEST=
> >
> >
> > Please review this at https://chromiumcodereview.appspot.com/10823037/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >   M chrome/browser/sync/glue/DEPS
> >   M chrome/browser/sync/glue/bridged_sync_notifier.h
> >   M chrome/browser/sync/glue/bridged_sync_notifier.cc
> >   M chrome/browser/sync/glue/bridged_sync_notifier_unittest.cc
> >   M chrome/browser/sync/glue/chrome_sync_notification_bridge.h
> >   M chrome/browser/sync/glue/chrome_sync_notification_bridge.cc
> >   M chrome/browser/sync/glue/chrome_sync_notification_bridge_unittest.cc
> >   M sync/internal_api/sync_manager_impl.h
> >   M sync/internal_api/sync_manager_impl.cc
> >   M sync/internal_api/syncapi_unittest.cc
> >   M sync/notifier/chrome_invalidation_client.h
> >   M sync/notifier/invalidation_notifier.h
> >   M sync/notifier/invalidation_notifier.cc
> >   M sync/notifier/invalidation_notifier_unittest.cc
> >   M sync/notifier/invalidation_util.h
> >   M sync/notifier/invalidation_util.cc
> >   M sync/notifier/mock_sync_notifier_observer.h
> >   M sync/notifier/non_blocking_invalidation_notifier.h
> >   M sync/notifier/non_blocking_invalidation_notifier.cc
> >   M sync/notifier/non_blocking_invalidation_notifier_unittest.cc
> >   D sync/notifier/object_id_payload_map.h
> >   D sync/notifier/object_id_payload_map.cc
> >   M sync/notifier/p2p_notifier.h
> >   M sync/notifier/p2p_notifier.cc
> >   M sync/notifier/p2p_notifier_unittest.cc
> >   M sync/notifier/sync_notifier.h
> >   M sync/notifier/sync_notifier_factory_unittest.cc
> >   D sync/notifier/sync_notifier_helper.h
> >   D sync/notifier/sync_notifier_helper.cc
> >   D sync/notifier/sync_notifier_helper_unittest.cc
> >   M sync/notifier/sync_notifier_observer.h
> >   M sync/sync.gyp
> >   M sync/tools/sync_listen_notifications.cc
> >
> >
>
>