Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/sync/glue/chrome_sync_notification_bridge.h

Issue 10823037: Revert r148496 "Refactor sync-specific parts out of SyncNotifier/SyncNotifierObserver" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_
6 #define CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/sequenced_task_runner.h" 10 #include "base/sequenced_task_runner.h"
11 #include "content/public/browser/notification_observer.h" 11 #include "content/public/browser/notification_observer.h"
12 #include "content/public/browser/notification_registrar.h" 12 #include "content/public/browser/notification_registrar.h"
13 #include "sync/internal_api/public/base/model_type.h" 13 #include "sync/internal_api/public/base/model_type.h"
14 #include "sync/notifier/invalidation_util.h"
15 14
16 class Profile; 15 class Profile;
17 16
18 namespace syncer { 17 namespace syncer {
19 class SyncNotifierObserver; 18 class SyncNotifierObserver;
20 } // namespace 19 } // namespace
21 20
22 namespace browser_sync { 21 namespace browser_sync {
23 22
24 // A bridge that converts Chrome events on the UI thread to sync 23 // A bridge that converts Chrome events on the UI thread to sync
25 // notifications on the sync task runner. 24 // notifications on the sync task runner.
26 // 25 //
27 // Listens to NOTIFICATION_SYNC_REFRESH_LOCAL and 26 // Listens to NOTIFICATION_SYNC_REFRESH_LOCAL and
28 // NOTIFICATION_SYNC_REFRESH_REMOTE (on the UI thread) and triggers 27 // NOTIFICATION_SYNC_REFRESH_REMOTE (on the UI thread) and triggers
29 // each observer's OnIncomingNotification method on these 28 // each observer's OnIncomingNotification method on these
30 // notifications (on the sync task runner). 29 // notifications (on the sync task runner).
31 class ChromeSyncNotificationBridge : public content::NotificationObserver { 30 class ChromeSyncNotificationBridge : public content::NotificationObserver {
32 public: 31 public:
33 // Must be created and destroyed on the UI thread. 32 // Must be created and destroyed on the UI thread.
34 ChromeSyncNotificationBridge( 33 ChromeSyncNotificationBridge(
35 const Profile* profile, 34 const Profile* profile,
36 const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner); 35 const scoped_refptr<base::SequencedTaskRunner>& sync_task_runner);
37 virtual ~ChromeSyncNotificationBridge(); 36 virtual ~ChromeSyncNotificationBridge();
38 37
39 // Must be called on the sync task runner. 38 // Must be called on the sync task runner.
40 void UpdateEnabledTypes(syncer::ModelTypeSet enabled_types); 39 void UpdateEnabledTypes(syncer::ModelTypeSet enabled_types);
41 // Marked virtual for tests. 40 // Marked virtual for tests.
42 virtual void UpdateRegisteredIds(syncer::SyncNotifierObserver* handler, 41 virtual void AddObserver(syncer::SyncNotifierObserver* observer);
43 const syncer::ObjectIdSet& ids); 42 virtual void RemoveObserver(syncer::SyncNotifierObserver* observer);
44 43
45 // NotificationObserver implementation. Called on UI thread. 44 // NotificationObserver implementation. Called on UI thread.
46 virtual void Observe(int type, 45 virtual void Observe(int type,
47 const content::NotificationSource& source, 46 const content::NotificationSource& source,
48 const content::NotificationDetails& details) OVERRIDE; 47 const content::NotificationDetails& details) OVERRIDE;
49 48
50 private: 49 private:
51 // Inner class to hold all the bits used on |sync_task_runner_|. 50 // Inner class to hold all the bits used on |sync_task_runner_|.
52 class Core; 51 class Core;
53 52
54 const scoped_refptr<base::SequencedTaskRunner> sync_task_runner_; 53 const scoped_refptr<base::SequencedTaskRunner> sync_task_runner_;
55 54
56 // Created on the UI thread, used only on |sync_task_runner_|. 55 // Created on the UI thread, used only on |sync_task_runner_|.
57 const scoped_refptr<Core> core_; 56 const scoped_refptr<Core> core_;
58 57
59 // Used only on the UI thread. 58 // Used only on the UI thread.
60 content::NotificationRegistrar registrar_; 59 content::NotificationRegistrar registrar_;
61 }; 60 };
62 61
63 } // namespace browser_sync 62 } // namespace browser_sync
64 63
65 #endif // CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_ 64 #endif // CHROME_BROWSER_SYNC_GLUE_CHROME_SYNC_NOTIFICATION_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698