Consume TAP regardless of menu result to avoid setting HOT state in CustomButton.

ui/views/controls/button/menu_button.cc

Index: ui/views/controls/button/menu_button.cc
diff --git a/ui/views/controls/button/menu_button.cc b/ui/views/controls/button/menu_button.cc
index 23607f4eb56b4279bd1c44c6c31b9077279c5eed..0c4be83837c5615a493d096183b9adc6d40223fd 100644
--- a/ui/views/controls/button/menu_button.cc
+++ b/ui/views/controls/button/menu_button.cc
@@ -222,8 +222,8 @@ void MenuButton::OnMouseExited(const MouseEvent& event) {
 
 ui::GestureStatus MenuButton::OnGestureEvent(const GestureEvent& event) {
   if (state() != BS_DISABLED && event.type() == ui::ET_GESTURE_TAP) {
-    if (Activate())
-      return ui::GESTURE_STATUS_CONSUMED;
+    ignore_result(Activate());

[sky, 2012/07/25 00:48:42]

You don't need ignore_result here. Are you sure the bug isn't that this should
be if (!Activate()) ?

[flackr, 2012/07/25 01:31:59]

Yes, Activate blocks until the menu completion, after which it will return the
button state to BS_NORMAL which we don't want to change after the fact in
TextButton::OnGestureEvent. Removed ignore_result, done.

+    return ui::GESTURE_STATUS_CONSUMED;
   }
   return TextButton::OnGestureEvent(event);
 }