Consume TAP regardless of menu result to avoid setting HOT state in CustomButton.

ui/views/controls/button/menu_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/menu_button.h"
 
 #include "base/utf_string_conversions.h"
 #include "grit/ui_resources.h"
 #include "grit/ui_strings.h"
 #include "ui/base/accessibility/accessible_view_state.h"
@@ skipping 204 matching lines @@
 // to BS_NORMAL instead of keeping the state BM_PUSHED. This, in turn, will
 // cause the button to appear depressed while the menu is displayed.
 void MenuButton::OnMouseExited(const MouseEvent& event) {
   if ((state_ != BS_DISABLED) && (!menu_visible_) && (!InDrag())) {
     SetState(BS_NORMAL);
   }
 }
 
 ui::GestureStatus MenuButton::OnGestureEvent(const GestureEvent& event) {
   if (state() != BS_DISABLED && event.type() == ui::ET_GESTURE_TAP) {
-    if (Activate())
-      return ui::GESTURE_STATUS_CONSUMED;
+    ignore_result(Activate());

[sky, 2012/07/25 00:48:42]

You don't need ignore_result here. Are you sure the bug isn't that this should
be if (!Activate()) ?

[flackr, 2012/07/25 01:31:59]

Yes, Activate blocks until the menu completion, after which it will return the
button state to BS_NORMAL which we don't want to change after the fact in
TextButton::OnGestureEvent. Removed ignore_result, done.

+    return ui::GESTURE_STATUS_CONSUMED;
   }
   return TextButton::OnGestureEvent(event);
 }
 
 bool MenuButton::OnKeyPressed(const KeyEvent& event) {
   switch (event.key_code()) {
     case ui::VKEY_SPACE:
       // Alt-space on windows should show the window menu.
       if (event.IsAltDown())
         break;
@@ skipping 27 matching lines @@
   if (!GetWidget()) {
     NOTREACHED();
     return 0;
   }
 
   gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
   return monitor_bounds.right() - 1;
 }
 
 }  // namespace views