Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10822030: Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. (Closed)

Created:
8 years, 5 months ago by jam
Modified:
8 years, 5 months ago
CC:
chromium-reviews, jam, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, rginda+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, yoshiki+watch_chromium.org, ncarter (slow), Ilya Sherman, achuith+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, gbillock+watch_chromium.org, tim (not reviewing), rdsmith+dwatch_chromium.org, kkania, Raghu Simha, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, oshima+watch_chromium.org, mihaip-chromium-reviews_chromium.org, akalin, tfarina, Aaron Boodman, dominich+watch_chromium.org, robertshield, mmenke, dyu1, smckay+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. BUG=90448 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148514

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -155 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_tab_helper_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_documents_service_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/process_proxy/process_proxy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_test_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_notification_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/convert_web_app_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_test_message_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/access_token_store_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/toolbar_importer_utils_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/logging_chrome_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_cycler/page_cycler_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/printing_layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search_engines/template_url_scraper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_test_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/test/base/ui_test_utils_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/ui_test_utils_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/idbbindingutilities_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/test_utils.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/test_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 5 months ago (2012-07-26 03:40:44 UTC) #1
Ben Goodger (Google)
8 years, 5 months ago (2012-07-26 03:56:34 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698