chrome/browser/ui/views/web_dialog_view_browsertest.cc - Issue 10822030: Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 10822030: Move ui_test_utils::RunMessageLoop to test_utils so that it can be reused by content_browsertests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/one_click_signin_bubble_view_browsertest.cc ('k') | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc

===================================================================

--- chrome/browser/ui/views/web_dialog_view_browsertest.cc (revision 148497)

+++ chrome/browser/ui/views/web_dialog_view_browsertest.cc (working copy)

@@ -121,7 +121,7 @@

set_bounds.set_height(300);

view->MoveContents(web_contents, set_bounds);

- ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.

+ content::RunMessageLoop(); // TestWebDialogView will quit.

actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();

EXPECT_EQ(set_bounds, actual_bounds);

@@ -137,7 +137,7 @@

set_bounds.set_height(250);

view->MoveContents(web_contents, set_bounds);

- ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.

+ content::RunMessageLoop(); // TestWebDialogView will quit.

actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();

EXPECT_EQ(set_bounds, actual_bounds);

@@ -153,7 +153,7 @@

set_bounds.set_size(min_size);

view->MoveContents(web_contents, set_bounds);

- ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.

+ content::RunMessageLoop(); // TestWebDialogView will quit.

actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();

EXPECT_EQ(set_bounds, actual_bounds);

@@ -169,7 +169,7 @@

set_bounds.set_height(0);

view->MoveContents(web_contents, set_bounds);

- ui_test_utils::RunMessageLoop(); // TestWebDialogView will quit.

+ content::RunMessageLoop(); // TestWebDialogView will quit.

actual_bounds = view->GetWidget()->GetClientAreaBoundsInScreen();

EXPECT_LT(0, actual_bounds.width());

EXPECT_LT(0, actual_bounds.height());